Skip to content

Commit

Permalink
test/bonding: remove unreachable statement
Browse files Browse the repository at this point in the history
[ upstream commit 9f4f98c9898fc6aa730ed02571790aa0b2ac4813 ]

CI found that execution cannot reach the expression "else"
inside this statement.

Coverity issue: 403097
Fixes: 5e41ab2 ("app/test: unit tests for bonding mode 4")

Signed-off-by: Long Wu <long.wu@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
  • Loading branch information
wulong2022 authored and kevintraynor committed Nov 15, 2023
1 parent df93e5c commit 1c29c23
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions app/test/test_link_bonding_mode4.c
Original file line number Diff line number Diff line change
Expand Up @@ -643,8 +643,7 @@ bond_handshake(void)
/* If response didn't send - report failure */
TEST_ASSERT_EQUAL(all_slaves_done, 1, "Bond handshake failed\n");

/* If flags doesn't match - report failure */
return all_slaves_done == 1 ? TEST_SUCCESS : TEST_FAILED;
return TEST_SUCCESS;
}

#define TEST_LACP_SLAVE_COUT RTE_DIM(test_params.slave_ports)
Expand Down

0 comments on commit 1c29c23

Please sign in to comment.