Skip to content

Commit

Permalink
net/hns3: fix crash in SVE Tx
Browse files Browse the repository at this point in the history
[ upstream commit 905487d ]

Currently, the number of Tx send bytes is obtained by accumulating the
length of the batch 'mbuf' packets of the current loop cycle.
Unfortunately, it uses svcntd (which means all lane, regardless of
whether the corresponding lane is valid) which may lead to overflow,
and thus refers to an invalid mbuf.

Because the SVE xmit algorithm applies only to a single mbuf, the
mbuf's data_len is equal pkt_len, so this patch fixes it by using
svaddv_u64(svbool_t pg, svuint64_t data_len) which only adds valid
lanes.

Fixes: fdcd6a3 ("net/hns3: add bytes stats")

Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
Signed-off-by: Dongdong Liu <liudongdong3@huawei.com>
  • Loading branch information
fengchengwen authored and kevintraynor committed Oct 20, 2022
1 parent 5210f64 commit 2197709
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions drivers/net/hns3/hns3_rxtx_vec_sve.c
Expand Up @@ -435,9 +435,8 @@ hns3_tx_fill_hw_ring_sve(struct hns3_tx_queue *txq,
offsets, svdup_n_u64(valid_bit));

/* Increment bytes counter */
uint32_t idx;
for (idx = 0; idx < svcntd(); idx++)
txq->basic_stats.bytes += pkts[idx]->pkt_len;
txq->basic_stats.bytes +=
(svaddv_u64(pg, data_len) >> HNS3_UINT16_BIT);

/* update index for next loop */
i += svcntd();
Expand Down

0 comments on commit 2197709

Please sign in to comment.