Skip to content

Commit

Permalink
common/sfc_efx/base: fix Rx queue without RSS hash prefix
Browse files Browse the repository at this point in the history
[ upstream commit 80d18a958e4f06e121327073439c391dbc870d80 ]

If the prefix for the RSS hash was not chosen the ENOTSUP error should
be returned.

Before this patch success was returned for this case causing Rx queue
creation to fail.

Fixing return value to indicate failure.

Fixes: f784cdc ("common/sfc_efx/base: provide control to deliver RSS hash")

Signed-off-by: Artemii Morozov <artemii.morozov@arknetworks.am>
Reviewed-by: Andy Moreton <amoreton@xilinx.com>
Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
  • Loading branch information
okt-artemii authored and kevintraynor committed Jul 12, 2023
1 parent 95e5d43 commit 21e4c85
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/common/sfc_efx/base/efx_rx.c
Original file line number Diff line number Diff line change
Expand Up @@ -896,8 +896,10 @@ efx_rx_qcreate_internal(

rss_hash_field =
&erplp->erpl_fields[EFX_RX_PREFIX_FIELD_RSS_HASH];
if (rss_hash_field->erpfi_width_bits == 0)
if (rss_hash_field->erpfi_width_bits == 0) {
rc = ENOTSUP;
goto fail5;
}
}

enp->en_rx_qcount++;
Expand Down

0 comments on commit 21e4c85

Please sign in to comment.