Skip to content

Commit

Permalink
net/virtio: fix uninitialized RSS key
Browse files Browse the repository at this point in the history
[ upstream commit 0f7438e ]

This patch fixes an issue that uninitialized old_rss_key
is used for restoring the rss_key.

Coverity issue: 373866
Fixes: 0c9d662 ("net/virtio: support RSS")

Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
  • Loading branch information
wyjwang authored and kevintraynor committed Feb 21, 2022
1 parent 0d2ddde commit 4c4c0cf
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/net/virtio/virtio_ethdev.c
Expand Up @@ -2028,7 +2028,8 @@ virtio_dev_rss_hash_update(struct rte_eth_dev *dev,

return 0;
restore_key:
memcpy(hw->rss_key, old_rss_key, VIRTIO_NET_RSS_KEY_SIZE);
if (rss_conf->rss_key && rss_conf->rss_key_len)
memcpy(hw->rss_key, old_rss_key, VIRTIO_NET_RSS_KEY_SIZE);
restore_types:
hw->rss_hash_types = old_hash_types;

Expand Down

0 comments on commit 4c4c0cf

Please sign in to comment.