Skip to content

Commit

Permalink
net/txgbe: fix interrupt enable mask
Browse files Browse the repository at this point in the history
[ upstream commit 646b058472cdfb503a0c555ed2e0f891c05437a7 ]

When using no LSC mode, GPIO interrupt can still cause
txgbe_dev_interrupt_delayed_handler() to be called, with
TXGBE_FLAG_NEED_LINK_UPDATE to be set. So add a LSC condition on
intr->mask_misc.

Fixes: 2fc745e ("net/txgbe: add interrupt operation")
Fixes: d3bb4a04eac1 ("net/txgbe: add SFP hotplug identification")

Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
  • Loading branch information
Jiawen Wu authored and kevintraynor committed Jul 12, 2023
1 parent 1a77552 commit 5b72e18
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/net/txgbe/txgbe_ethdev.c
Original file line number Diff line number Diff line change
Expand Up @@ -3133,7 +3133,8 @@ txgbe_dev_interrupt_delayed_handler(void *param)
}

/* restore original mask */
intr->mask_misc |= TXGBE_ICRMISC_LSC;
if (dev->data->dev_conf.intr_conf.lsc == 1)
intr->mask_misc |= TXGBE_ICRMISC_LSC;

intr->mask = intr->mask_orig;
intr->mask_orig = 0;
Expand Down

0 comments on commit 5b72e18

Please sign in to comment.