Skip to content

Commit

Permalink
net/mlx5: fix unlimited parsing of switch info
Browse files Browse the repository at this point in the history
In mlx5_sysfs_switch_info function, the driver gets switch information
associated with network interface.

The driver writes the port name into buffer and translates it.
However, when it writes the name, it does not limit writing to the
buffer size.

Limit writing to the size of the buffer.

Fixes: 1256805 ("net/mlx5: move Linux-specific functions")
Cc: stable@dpdk.org

Signed-off-by: Michael Baum <michaelba@mellanox.com>
Acked-by: Matan Azrad <matan@mellanox.com>
  • Loading branch information
michaelbaum1 authored and Ferruh Yigit committed Jul 29, 2020
1 parent 4a28e83 commit 63d1db7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/mlx5/linux/mlx5_ethdev_os.c
Original file line number Diff line number Diff line change
Expand Up @@ -1067,7 +1067,7 @@ mlx5_sysfs_switch_info(unsigned int ifindex, struct mlx5_switch_info *info)

file = fopen(phys_port_name, "rb");
if (file != NULL) {
ret = fscanf(file, "%s", port_name);
ret = fscanf(file, "%" RTE_STR(IF_NAMESIZE) "s", port_name);
fclose(file);
if (ret == 1)
mlx5_translate_port_name(port_name, &data);
Expand Down

0 comments on commit 63d1db7

Please sign in to comment.