Skip to content

Commit

Permalink
net/af_xdp: make compatible with libbpf 0.8.0
Browse files Browse the repository at this point in the history
[ upstream commit 1eb1846 ]

libbpf v0.8.0 deprecates the bpf_get_link_xdp_id() and
bpf_set_link_xdp_fd() functions. Use meson to detect if
bpf_xdp_attach() is available and if so, use the recommended
replacement functions bpf_xdp_query_id(), bpf_xdp_attach()
and bpf_xdp_detach().

Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Reviewed-by: Ferruh Yigit <ferruh.yigit@xilinx.com>
  • Loading branch information
cloftus authored and kevintraynor committed Dec 7, 2023
1 parent 9bb15a3 commit 770e7c2
Show file tree
Hide file tree
Showing 2 changed files with 45 additions and 1 deletion.
8 changes: 8 additions & 0 deletions drivers/net/af_xdp/meson.build
Original file line number Diff line number Diff line change
Expand Up @@ -55,3 +55,11 @@ else
build = false
reason = 'missing header, "linux/if_xdp.h"'
endif

if build
if cc.has_function('bpf_xdp_attach',
prefix : '#include <bpf/libbpf.h>',
dependencies : bpf_dep)
cflags += ['-DRTE_NET_AF_XDP_LIBBPF_XDP_ATTACH']
endif
endif
38 changes: 37 additions & 1 deletion drivers/net/af_xdp/rte_eth_af_xdp.c
Original file line number Diff line number Diff line change
Expand Up @@ -858,9 +858,43 @@ eth_stats_reset(struct rte_eth_dev *dev)
return 0;
}

#ifdef RTE_NET_AF_XDP_LIBBPF_XDP_ATTACH

static int link_xdp_prog_with_dev(int ifindex, int fd, __u32 flags)
{
return bpf_xdp_attach(ifindex, fd, flags, NULL);
}

static int
remove_xdp_program(struct pmd_internals *internals)
{
uint32_t curr_prog_id = 0;
int ret;

ret = bpf_xdp_query_id(internals->if_index, XDP_FLAGS_UPDATE_IF_NOEXIST,
&curr_prog_id);
if (ret != 0) {
AF_XDP_LOG(ERR, "bpf_xdp_query_id failed\n");
return ret;
}

ret = bpf_xdp_detach(internals->if_index, XDP_FLAGS_UPDATE_IF_NOEXIST,
NULL);
if (ret != 0)
AF_XDP_LOG(ERR, "bpf_xdp_detach failed\n");
return ret;
}

#else

#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"

static int link_xdp_prog_with_dev(int ifindex, int fd, __u32 flags)
{
return bpf_set_link_xdp_fd(ifindex, fd, flags);
}

static void
remove_xdp_program(struct pmd_internals *internals)
{
Expand All @@ -877,6 +911,8 @@ remove_xdp_program(struct pmd_internals *internals)

#pragma GCC diagnostic pop

#endif

static void
xdp_umem_destroy(struct xsk_umem_info *umem)
{
Expand Down Expand Up @@ -1189,7 +1225,7 @@ load_custom_xdp_prog(const char *prog_path, int if_index, struct bpf_map **map)
}

/* Link the program with the given network device */
ret = bpf_set_link_xdp_fd(if_index, prog_fd,
ret = link_xdp_prog_with_dev(if_index, prog_fd,
XDP_FLAGS_UPDATE_IF_NOEXIST);
if (ret) {
AF_XDP_LOG(ERR, "Failed to set prog fd %d on interface\n",
Expand Down

0 comments on commit 770e7c2

Please sign in to comment.