Skip to content

Commit

Permalink
crypto/scheduler: fix last element for valid args
Browse files Browse the repository at this point in the history
[ upstream commit 34019b7b65d4d936649fab29fdee45ec3ada1a8d ]

The list of valid arguments for Scheduler PMD should be terminated with
a NULL entry, as expected by rte_kvargs_parse.

Without this, if an invalid key name was used, a global buffer overflow
occurred resulting in a segmentation fault.

Fixes: 503e9c5 ("crypto/scheduler: register as vdev driver")

Signed-off-by: Ciara Power <ciara.power@intel.com>
Acked-by: Kai Ji <kai.ji@intel.com>
  • Loading branch information
ciarapow authored and kevintraynor committed Jul 11, 2023
1 parent 54fa9bd commit 792da5f
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/crypto/scheduler/scheduler_pmd.c
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ static const char * const scheduler_valid_params[] = {
RTE_CRYPTODEV_VDEV_MAX_NB_QP_ARG,
RTE_CRYPTODEV_VDEV_SOCKET_ID,
RTE_CRYPTODEV_VDEV_COREMASK,
RTE_CRYPTODEV_VDEV_CORELIST
RTE_CRYPTODEV_VDEV_CORELIST,
NULL
};

struct scheduler_parse_map {
Expand Down

0 comments on commit 792da5f

Please sign in to comment.