Skip to content

Commit

Permalink
net/qede: fix redundant condition in debug code
Browse files Browse the repository at this point in the history
[ upstream commit 6caee3f ]

Expression "a && 1" is equivalent to just "a", so fix the accidental
inclusion of a literal in code.

Fixes: ec55c11 ("net/qede: add infrastructure for debug data collection")

Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
Acked-by: Devendra Singh Rawat <dsinghrawat@marvell.com>
Reviewed-by: Igor Russkikh <irusskikh@marvell.com>
Acked-by: Rasesh Mody <rmody@marvell.com>
  • Loading branch information
anatolyburakov authored and kevintraynor committed Feb 21, 2022
1 parent 9ff875e commit f1339fd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/qede/qede_debug.c
Expand Up @@ -3522,7 +3522,7 @@ static enum dbg_status qed_grc_dump(struct ecore_hwfn *p_hwfn,

/* Dump MCP HW Dump */
if (qed_grc_is_included(p_hwfn, DBG_GRC_PARAM_DUMP_MCP_HW_DUMP) &&
!qed_grc_get_param(p_hwfn, DBG_GRC_PARAM_NO_MCP) && 1)
!qed_grc_get_param(p_hwfn, DBG_GRC_PARAM_NO_MCP))
offset += qed_grc_dump_mcp_hw_dump(p_hwfn,
p_ptt,
dump_buf + offset, dump);
Expand Down

0 comments on commit f1339fd

Please sign in to comment.