Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conceptual bug!! #3

Closed
rash1993 opened this issue Oct 24, 2017 · 3 comments
Closed

Conceptual bug!! #3

rash1993 opened this issue Oct 24, 2017 · 3 comments

Comments

@rash1993
Copy link

Hi,

In the script main.py, it's cool that you input the output of the localization network to the spatial transformer to obtain the transformed image as h_trans. But, post that you are providing the initial (original/untransformed) image to the convolutional network. Should not it be the transformed image (h_trans) that should go through the CNN?

I trained the model over the complete dataset (using the script as it is), but the transformations learned are not what expected. It seems to be random! Which is justified in the current scenario as the localization is not part of the optimization routine!

@kevinzakka
Copy link
Owner

Hey man, you're absolutely right. I haven't taken a look at the repo in a long time, and never updated it to the last version I had locally due to breaking tensorflow changes that happened a few months ago. I'll fix the error, but also need to take a look at whatever broke in the update as well.

Thanks for spotting that though :)

@rash1993
Copy link
Author

I don't think there are many changes needed, as far as the latest version of the tensorflow is concerned! Anyways, it is a useful repository! Thanks! :)

@kevinzakka
Copy link
Owner

No worries, feel free to open this up if you find any more issues.

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants