Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_photos() #289

Merged
merged 4 commits into from
May 25, 2021
Merged

Add get_photos() #289

merged 4 commits into from
May 25, 2021

Conversation

lennoxho
Copy link
Contributor

No description provided.

@lennoxho
Copy link
Contributor Author

Note I've removed

assert self.cursor_blob is not None

Somehow the "script" cmd is sometimes missing from the JSON response.
Only happens in some instances.

@lennoxho lennoxho mentioned this pull request May 25, 2021
@neon-ninja
Copy link
Collaborator

This breaks get_posts, with the error TypeError: get_page() missing 2 required positional arguments: 'selection' and 'selection_name'

@neon-ninja
Copy link
Collaborator

I think get_photos should also extract all the other usual fields - post id, text, time etc

@neon-ninja
Copy link
Collaborator

This would solve #111

@lennoxho
Copy link
Contributor Author

This breaks get_posts, with the error TypeError: get_page() missing 2 required positional arguments: 'selection' and 'selection_name'

Oops. That's embarrassing.
I swear I test my stuff in my day job

Added new "smoketest"s.

@lennoxho
Copy link
Contributor Author

I think get_photos should also extract all the other usual fields - post id, text, time etc

Unfortunately, photo "posts" are not real Posts.

This is all we have to work with with photo "posts":
Untitled

There are no references to post_id, actor-link, page_insights or user_id.

That said, page_insights and user_id are available in the "Full Size" page.
But I feel like this can be done later in another changelist.

@neon-ninja
Copy link
Collaborator

Fair enough, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants