TraceContext cleanup

kevmoo · Sep 20, 2023 · 7d72fa4 · 7d72fa4
1 parent f2b7add
commit 7d72fa4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/server/lib/src/trace_context.dart b/server/lib/src/trace_context.dart
@@ -3,10 +3,10 @@ import 'dart:typed_data';
 
 class TraceContext {
   final String traceId;
-  final String parentId;
+  final String spaceId;
   final String traceFlags;
 
-  TraceContext._(this.traceId, this.parentId, this.traceFlags);
+  TraceContext._(this.traceId, this.spaceId, this.traceFlags);
 
   factory TraceContext.parse(String input) {
     final sections = input.split('-');
@@ -25,7 +25,9 @@ class TraceContext {
     );
   }
 
-  /// Returns a new [TraceContext] with a randomized [parentId].
+  /// Returns a new [TraceContext] with a randomized [spaceId].
+  ///
+  /// If [random] is not provided a new instance of [Random] is used.
   TraceContext randomize({Random? random}) {
     random ??= Random();
 
@@ -46,7 +48,7 @@ class TraceContext {
   }
 
   @override
-  String toString() => '00-$traceId-$parentId-$traceFlags';
+  String toString() => '00-$traceId-$spaceId-$traceFlags';
 }
 
 final _hexThing = RegExp(r'^(?:[0-9a-f][0-9a-f])+$');

diff --git a/server/test/trace_context_test.dart b/server/test/trace_context_test.dart
@@ -76,7 +76,7 @@ void main() {
         final randomized = value.randomize();
         expect(randomized.traceId, value.traceId);
         expect(randomized.traceFlags, value.traceFlags);
-        expect(randomized.parentId, isNot(value.parentId));
+        expect(randomized.spaceId, isNot(value.spaceId));
         expect(
           TraceContext.parse(randomized.toString()).toString(),
           randomized.toString(),