Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peanut does not invode flutter build web #135

Closed
white-gecko opened this issue Aug 20, 2022 · 14 comments · Fixed by #158
Closed

peanut does not invode flutter build web #135

white-gecko opened this issue Aug 20, 2022 · 14 comments · Fixed by #158
Assignees
Labels

Comments

@white-gecko
Copy link

Similar to the case of #95

flutter is not detected when running on github actions and installing flutter with https://github.com/subosito/flutter-action .

The MWE for my case is basically https://github.com/white-gecko/flutter_peanut_mwe.

The FLUTTER_ROOT is /opt/hostedtoolcache/flutter/stable-3.0.5-x64.

It terminates with:

Validating packages:
  /home/runner/work/flutter_peanut_mwe/flutter_peanut_mwe
You must have a dependency on `build_runner` in `pubspec.yaml`.
# pubspec.yaml
dev_dependencies:
  build_runner: >=1.3.0 <3.0.0
You must have a dependency on `build_web_compilers` in `pubspec.yaml`.
# pubspec.yaml
dev_dependencies:
  build_web_compilers: >=1.2.0 <4.0.0
pub finished with exit code 78

The complete log is: rawlog.txt

But as I understand it, it should not be asking for build_runner and build_web_compilers if it would run flutter build web.

@kevmoo
Copy link
Owner

kevmoo commented Sep 7, 2022

What's in your pubspec?

@kevmoo
Copy link
Owner

kevmoo commented Sep 7, 2022

does flutter doctor work from the same directory?

@kevmoo
Copy link
Owner

kevmoo commented Jan 18, 2023

@white-gecko – any more info here?

@white-gecko
Copy link
Author

white-gecko commented Jan 18, 2023

Sorry for not reacting, its all available here: https://github.com/white-gecko/flutter_peanut_mwe respectively here: https://github.com/white-gecko/flutter_peanut_mwe/blob/main/.github/workflows/distribute_web.yml

The error can be seen here: https://github.com/white-gecko/flutter_peanut_mwe/actions/runs/3947810376/jobs/6757067464

I've added a flutter doctor step now, lets see, what it says.

@white-gecko
Copy link
Author

@kateile
Copy link

kateile commented May 5, 2023

I have the same problem in Github action. Locally everything works fine. Maybe there is bug in https://github.com/subosito/flutter-action.

@white-gecko have you found the exactly problem?

@white-gecko
Copy link
Author

No, I did not.
I just created my own script to checkout the deployment branch to a temporary folder and commit the new build to that branch.

@kevmoo
Copy link
Owner

kevmoo commented May 6, 2023

I've been very busy looking at I/O things. I'll see if I can dig in here soon. Thanks for your patience!

@kevmoo
Copy link
Owner

kevmoo commented May 7, 2023

Is there no web app? It may be failing without a web app.

The runs that you point to here have expired @white-gecko – could you re-run?

@white-gecko
Copy link
Author

@kevmoo
Copy link
Owner

kevmoo commented May 10, 2023

Just for sanity sake, @white-gecko – would you copy-paste the pubspec.yaml file here?

@kevmoo kevmoo self-assigned this May 10, 2023
@kevmoo kevmoo added bug and removed Needs info labels May 10, 2023
kevmoo added a commit that referenced this issue May 11, 2023
kevmoo added a commit that referenced this issue May 16, 2023
@kevmoo
Copy link
Owner

kevmoo commented May 16, 2023

@white-gecko – any way you could download and try out #158 ??

I'd LOVE to make sure this fixes things for you

kevmoo added a commit that referenced this issue May 16, 2023
@kevmoo
Copy link
Owner

kevmoo commented May 17, 2023

v5 is out! Let me know if it helps

@white-gecko
Copy link
Author

Thank you! Sorry for not reacting earlier. Since I had adjusted the workflow already it is no simple drop in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants