Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button focus and disabled improvements #130

Merged
merged 3 commits into from Dec 27, 2022
Merged

Button focus and disabled improvements #130

merged 3 commits into from Dec 27, 2022

Conversation

lkhrs
Copy link
Collaborator

@lkhrs lkhrs commented Dec 24, 2022

@netlify
Copy link

netlify bot commented Dec 24, 2022 •
edited

✅ Deploy Preview for simplecss-cdn ready!

Name Link
🔨 Latest commit 5a97407
🔍 Latest deploy log https://app.netlify.com/sites/simplecss-cdn/deploys/63a73d638c2732000851425a
😎 Deploy Preview https://deploy-preview-130--simplecss-cdn.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@lkhrs
Copy link
Collaborator Author

lkhrs commented Dec 24, 2022

Styled outline for :focus-within per @waldyrious and @Visne's suggestions.

The following two screenshots are identical in Blink/Gecko.
Screenshot 2022-12-24 at 11 26 48
Screenshot 2022-12-24 at 11 26 26

WebKit renders the outline with square corners.
Screenshot 2022-12-24 at 12 00 48
Screenshot 2022-12-24 at 12 01 06

Visne
Visne approved these changes Dec 24, 2022
View reviewed changes
Copy link

@Visne Visne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Firefox and Chromium, works as expected and the outline looks awesome!

@lkhrs lkhrs merged commit 8f1cc1a into kevquirk:main Dec 27, 2022
@lkhrs lkhrs deleted the lkhrs/issue129 branch December 27, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Visne Visne Visne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Buttons stay highlighted after clicking
2 participants
@lkhrs @Visne