Move padding to summary for larger tap target
#38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `details` is closed, the padding on this element makes the box larger than the tap target, since you can only click on `summary` itself. By moving the padding to `summary` when `details` is collapsed, the tap target takes up the entire visual box. Then it can be moved back to `details` when expanded to keep padding around the contents. I suppose it's also possible to use `padding: unset` or similar for `details[open]` if you wanted to keep it more general than `padding: 0;` Love this simple library - I recognize a lot has gone into it. Thanks for maintaining!
|
Great catch and contribution. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
detailsis closed, the padding on this element makes the box larger than the tap target, since you can only click onsummaryitself. By moving the padding tosummarywhendetailsis collapsed, the tap target takes up the entire visual box. Then it can be moved back todetailswhen expanded to keep padding around the contents.Before:
(blue above is the tap target, so clicking on the padded area of
detailsdoes nothing, even though there's no visual distinction)After:
(entire box is now a tap target, with padding applied to
summaryelement when collapsed)I suppose it's also possible to use
padding: unsetor similar fordetails[open]if you wanted to keep it more general thanpadding: 0;. Also there are other ways to handle this in terms of CSS attribute selectors I'm sure but this is a start.Love this library - I recognize a lot has gone into it. Thanks for maintaining!