Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow symbolic links #18

Closed
offlinehacker opened this issue Mar 26, 2014 · 3 comments
Closed

Allow symbolic links #18

offlinehacker opened this issue Mar 26, 2014 · 3 comments

Comments

@offlinehacker
Copy link

This is worng: https://github.com/kevva/bin-wrapper/blob/master/index.js#L213

You should allow symbolic links, there's no reason why not, and that's exactly the use case we have in nix package manager and in nixos.

@kevva
Copy link
Owner

kevva commented Mar 26, 2014

Ok, so what did you mean by #16?

@offlinehacker
Copy link
Author

I will do some more testing and report you, but currently without #16 it
seems to work fine or at least it does not break and picks local binaries
:) It might be that the problem was in other library.

It might still be good to symlink global binaries to vendor folder. Then,
when you would run binary using bin-wrapper it would prefer binaries
specified through PATH, or else it would use symlinked ones. This way you
get deterministic environment and i think you would handle pretty much all
use cases.
On Mar 26, 2014 4:21 PM, "Kevin Mårtensson" notifications@github.com
wrote:

Ok, so what did you meant by #16#16
?

Reply to this email directly or view it on GitHubhttps://github.com//issues/18#issuecomment-38696822
.

@offlinehacker
Copy link
Author

After you fix https://github.com/kevva/find-file/issues/1 it should be fine. You should also remove 5b84720 or symlinks don't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants