Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not support list of media queries #1

Closed
wants to merge 4 commits into from
Closed

Does not support list of media queries #1

wants to merge 4 commits into from

Conversation

johno
Copy link

@johno johno commented Jan 12, 2015

Firstly, thanks for this project.

I've added a failing test case for the list of media queries. I'm currently attempting to modify the regex, I'll commit a fix as well if I'm successful.

Documentation: https://developer.mozilla.org/en-US/docs/Web/CSS/@import

@johno
Copy link
Author

johno commented Jan 13, 2015

An update:

I've been able to modify the regex slightly [A-Z\\s] => [A-Z,\\s] which allows it to match valid @import strings from the above MDN link. However, this approach is a bit too simplistic because it also matches invalid strings like @import url("bluish.css") projection,, tv;.

@johno
Copy link
Author

johno commented Jan 20, 2016

Closing due to my inactivity.

@johno johno closed this Jan 20, 2016
@johno johno deleted the handle-list-of-media-queries branch January 20, 2016 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant