Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JIMP To 0.10.1 #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

SteveSonoa
Copy link

Updated version of JIMP to 0.10.1. All tests continue to pass.

Among other bug fixes is an update to core-js, which is currently out-of-date and includes many issues. The package itself actually mentions this in the install logs:

npm WARN deprecated core-js@2.6.11: core-js@<3 is no longer maintained and not recommended for usage due to the number of issues. Please, upgrade your dependencies to the actual version of core-js@3.

Based on the logs of the package (linked above), there do not appear to be any breaking changes. I have run the yarn test suite, and all tests pass. I have installed this updated package in my own project, and all images are resizing as intended.

Thank you for your consideration of this merge request, and for the excellent package. We use it for RideTheTeacups.com.

@klouvas
Copy link

klouvas commented Oct 1, 2020

could we upgrade the jimp to version 0.16.1 to also fix https://hackerone.com/reports/842462 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants