Document unsupported formats #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I hit this and was wondering why I had a corrupt ico. This explains it. |
sindresorhus
changed the title
sindresorhus
changed the title
|
Merging this, but we should really find a better PNG encoder/decoder: #16 |
|
Some of this is incorrect. First and foremost, we're not using the linked module, but https://github.com/lukeapage/pngjs which does support interlacing. Indexed color is still unsupported though. |
Oh I see now, sorry for the misunderstanding. Most likely I got confused by the two modules having very similar names on npm ( |
|
No worries, it's understandable since there are a lot of forks of it with similar names :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After failing to convert a png to ico (I was getting an ico with pixels of random colors), I did some research and I found out that my image was in the indexed colormap format (8 bits per pixel), while pngjs only supports 8 bits per channel depth. I suggest adding this to the readme so users can find this out without needing to digg in the documentation of the underlying modules.