-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tld check should be disabled by default #12
Comments
This is so we can support URLs without protocols 25050cc. Without it would make this module quite loose, accepting pretty much anything with a |
Alright, I think we need at least an option then. Depending on the use case. If I want to use this regex to find URLs, I want to use the tld list, but only for matching URLs without protocol. Meaning, two patterns in one, one with tld list for only matching schemeless URLs and one without tld list for matching protocol URLs. I also have the use-case of wanting to "validate" and URL, which is kinda the use-case for the |
Yup, that sounds good to me. So the |
I was asking myself that and not sure. That's why I didn't mention it. I guess so. Yes to everything else. |
It's a little weird, because |
Hmm, I need to think about that. Let's revisit in a few days. |
ping @sindresorhus |
Or preferably just removed.
New tld's are coming out all the time and it's not feasible to keep it update to date. Even if you can, people using it won't and it will lead to annoying websites that doesn't accept
yo@cat.ninja
...The text was updated successfully, but these errors were encountered: