Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid matching ) after a slash at end of url #34

Closed
averissimo opened this issue Feb 8, 2017 · 5 comments
Closed

Avoid matching ) after a slash at end of url #34

averissimo opened this issue Feb 8, 2017 · 5 comments

Comments

@averissimo
Copy link

averissimo commented Feb 8, 2017

Example:

[and another](https://another.example.com/) and

image

first asked for in: yakyak/yakyak#578

@alebelcor
Copy link

alebelcor commented Mar 12, 2017

I was just about to report the same issue.

Here's a similar test using RunKit.

EDIT: Oh good, looks like there's a related pull request #35 😄

@averissimo
Copy link
Author

Yay!! looking forward to get it merged

@davibe
Copy link

davibe commented Apr 14, 2017

@kevva will you merge this ? we are waiting for it yakyak/yakyak#578

@kevva
Copy link
Owner

kevva commented May 21, 2017

See #35 (comment).

@sampsyo
Copy link

sampsyo commented Jun 2, 2017

FWIW the same issue exists with another Markdown convention: angle brackets for linked URLs.

> '<http://example.com>'.match(urlRegex())
[ 'http://example.com' ]
> '<http://example.com/>'.match(urlRegex())
[ 'http://example.com/>' ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants