Promisify #2
Closed
Promisify #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I'll check it out :). |
| console.log(dir); | ||
| //=> /home/johndoe/.local/share/Trash | ||
| }); | ||
|
|
||
| xdgTrashdir('foo.zip', function (err, dir) { | ||
| xdgTrashdir('foo.zip').then(function (dir) { | ||
| console.log(dir); | ||
| //=> /media/johndoe/UUI/.Trash-1000 | ||
| }); |
There was a problem hiding this comment.
Sindre always wants it to be this way on his modules:
const xdgTrashdir = require('xdg-trashdir');
xdgTrashdir().then(dir => {
console.log(dir);
//=> /home/johndoe/.local/share/Trash
});
xdgTrashdir('foo.zip').then(dir => {
console.log(dir);
//=> /media/johndoe/UUI/.Trash-1000
});Let me know what you prefer :)
There was a problem hiding this comment.
Oh, I didn't see this comment, but yeah, that's what I prefer too :).
| t.assert(dir === path.join(xdgBasedir.data, 'Trash'), dir); | ||
| }); | ||
| test('get the trash path', async t => { | ||
| var dir = await trashdir(); |
| return; | ||
| } | ||
| return Promise.all([ | ||
| pify(mountPoint, Promise)(userHome), |
There was a problem hiding this comment.
pify it once at the top of the file and reuse it here
| import {execFile} from 'child_process'; | ||
| import path from 'path'; | ||
| import test from 'ava'; | ||
| import xdgBaseDir from 'xdg-basedir'; |
There was a problem hiding this comment.
Good catch :)
|
Should we remove Node 0.10 tests out of travis? |
|
@SamVerschueren, yup, I did it in the same commit. Thank you :D! |
|
Nice! Thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I promisified the library and converted the tests to use ES2015.
I don't have a linux computer so I couldn't tested the script.