Action updates

kewisch · Jun 13, 2023 · e9d27a5 · e9d27a5
1 parent e831eda
commit e9d27a5
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -11,7 +11,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: "Checkout"
-        uses: actions/checkout@v2
+        uses: actions/checkout@v3
 
       - name: "Run ESLint"
         run: npx eslint src
@@ -20,14 +20,17 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: "Checkout"
-        uses: actions/checkout@v1
+        uses: actions/checkout@v3
+
+      - name: "npm ci"
+        run: npm ci
 
       - name: "Bump version"
         run: |
           export VERSION="1.$(echo ${GITHUB_SHA:0:4} | tr abcdef 123456).$(echo ${GITHUB_SHA:4:4} | tr abcdef 123456)"
           jq ".version = \"$VERSION\"" test/extension/manifest.json > manifest.json~
           mv manifest.json~ test/extension/manifest.json
-          git diff
+          git diff test/extension
 
       - name: "Self-test: lint"
         id: web-ext-lint

diff --git a/src/action.js b/src/action.js
@@ -103,7 +103,7 @@ export default class WebExtAction {
 
     await check.complete(summaryLine, nonfatal, fatal);
 
-    if (!this.options.token) {
+    if (!check.ready) {
       console.log(results.notices.concat(results.warnings).concat(results.errors).map(linterToString).join("\n") + "\n");
     }
     console.log(summaryLine);
@@ -134,6 +134,7 @@ export default class WebExtAction {
   async cmd_sign() {
     // Doing signing directly so we can pass in a source xpi as well
     let manifest = await getManifest(this.options.sourceDir);
+
     let id;
     try {
       id = manifest.browser_specific_settings.gecko.id;