Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep original file name #15

Closed
BoxJockey opened this issue Jan 28, 2023 · 13 comments
Closed

Keep original file name #15

BoxJockey opened this issue Jan 28, 2023 · 13 comments

Comments

@BoxJockey
Copy link

BoxJockey commented Jan 28, 2023

I'm glad to see 'Keep original file name' added as an option. I like to make batches of 2-4 of each image and choose the best one, and with 'Keep original file name' enabled it produces one image with 2-4 pictures on it. (Which is cool and probably useful for something) But would it be possible to output 'original file name-001' 'original file name-002' 'original file name-003'?

EDIT: Actually, with 'Keep original file name' change BFS now produces a single image with any batch size (all results in one image), regardless if 'Keep original file name' is enabled or not. Hope that makes sense...

kex0 added a commit that referenced this issue Jan 29, 2023
when batch count is > 1
@kex0
Copy link
Owner

kex0 commented Jan 29, 2023

Hey, I think what you mean is Batch COUNT, if so then you are correct. I forgot to take Batch COUNT to consideration. Batch SIZE always worked.

https://www.youtube.com/watch?v=hnhRKuQgpPU

With the latest commit it should correctly number files with batch count and batch size or combination of the two.
Thank you for the report.
Let me know it it's working as you would expect.

@BoxJockey
Copy link
Author

Yes, I meant Batch Count, sorry bout that. After updating I get 3 images with a Batch Count of 3, but the first image is all 3 images combined. The second and third images are correct.

@kex0
Copy link
Owner

kex0 commented Jan 29, 2023

I'm not sure why is that happening, try disabling this.
chrome_24e2nn4wl6

@BoxJockey
Copy link
Author

I don't have that enabled.

@kex0
Copy link
Owner

kex0 commented Jan 29, 2023

I don't know then, it's not happening to me. Maybe some other extension/script?

@BoxJockey
Copy link
Author

I'll try it without other extentions.

@BoxJockey
Copy link
Author

Yea, same results with no other extensions. I'll keep trying different things to see if I can find a reason...

@kex0
Copy link
Owner

kex0 commented Jan 29, 2023

  1. Does it happen only with one particular image? Or with every image?
  2. Is the first "combined" image like the image grid or how are they combined?
  3. Does it happen even if you provide output directory?

@BoxJockey
Copy link
Author

It happens with all images, even if I provide an output directory. The first image is the image grid (I haven't used that for so long I forgot it was a thing), the second image is the first actual image, so the missing image would be the last of the Batch Count.

kex0 added a commit that referenced this issue Jan 29, 2023
@kex0
Copy link
Owner

kex0 commented Jan 29, 2023

Try updating the extension and try again.

@kex0
Copy link
Owner

kex0 commented Jan 29, 2023

make sure you have the last commit, I made a mistake in a6a0512

commit b01e504

@BoxJockey
Copy link
Author

That is outputting correctly!

@BoxJockey
Copy link
Author

Thanks for your time! BFS is exactly what I need so I appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants