You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When generates the addXxx() interface for a VectorMember in podio_class_generator, it tries to drop the ‘s’ at the end of the variable name. But the last character is not always a 's'. This will lead to some strange function names. For example, in edm4hep::Cluster there are:
shape: addShap()
weight: addWeigh()
subdetectorEnergies: addSubdetectorEnergie()
I think we can simply replace the name 'weight' by ‘weights'. But it is not applicable for the 'shape' and 'subdetectorEnergies'.
The text was updated successfully, but these errors were encountered:
When generates the addXxx() interface for a VectorMember in podio_class_generator, it tries to drop the ‘s’ at the end of the variable name. But the last character is not always a 's'. This will lead to some strange function names. For example, in edm4hep::Cluster there are:
addShap()
addWeigh()
addSubdetectorEnergie()
I think we can simply replace the name 'weight' by ‘weights'. But it is not applicable for the 'shape' and 'subdetectorEnergies'.
The text was updated successfully, but these errors were encountered: