Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podio_class_generator generates strange names for VectorMembers #54

Closed
zoujh opened this issue Apr 28, 2020 · 3 comments
Closed

podio_class_generator generates strange names for VectorMembers #54

zoujh opened this issue Apr 28, 2020 · 3 comments

Comments

@zoujh
Copy link

zoujh commented Apr 28, 2020

When generates the addXxx() interface for a VectorMember in podio_class_generator, it tries to drop the ‘s’ at the end of the variable name. But the last character is not always a 's'. This will lead to some strange function names. For example, in edm4hep::Cluster there are:

  • shape: addShap()
  • weight: addWeigh()
  • subdetectorEnergies: addSubdetectorEnergie()

I think we can simply replace the name 'weight' by ‘weights'. But it is not applicable for the 'shape' and 'subdetectorEnergies'.

@vvolkl
Copy link
Collaborator

vvolkl commented Apr 28, 2020

Good catch. I think this should be fixed in podio - the relevant code seems to be here: https://github.com/AIDASoft/podio/blob/master/python/podio_class_generator.py#L490

@andresailer
Copy link
Collaborator

From the meeting discussion: change "add" to "addTo"

@andresailer
Copy link
Collaborator

Solved in podio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants