Make necessary changes for podio mutable classes #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
force-pushed
the
mutable-podio-classes
branch
2 times, most recently
from
822a7df
to
22b0f5a
Compare
|
@tmadlener - can you have a look at the failures? |
tmadlener
force-pushed
the
mutable-podio-classes
branch
from
22b0f5a
to
3013497
Compare
|
Yep, currently on it. Looks like I missed some pieces in the original branch I had prepared a few weeks/months back to illustrate the necessary changes. |
This was referenced Dec 6, 2021
tmadlener
force-pushed
the
mutable-podio-classes
branch
from
cd9eecc
to
0dc8830
Compare
|
Rebased to resolve conflicts. |
|
Merging this since this is the PR that all others depend on. |
vvolkl
added a commit
to vvolkl/k4RecCalorimeter
that referenced
this pull request
Feb 2, 2022
- Replace some dedicated types with `auto` and rename others (Cluster -> MutableCluster, ConstCluster -> Cluster) to adapt to the new naming scheme introduced in AIDASoft/podio#205. - The necessary changes in EDM4hep: key4hep/EDM4hep#132 would break this otherwise. Due to the explict use of Mutable* (in attachCells) this now requires a new version of edm4hep.
vvolkl
added a commit
to HEP-FCC/k4RecCalorimeter
that referenced
this pull request
Feb 3, 2022
* Adapt to new podio generated class names - Replace some dedicated types with `auto` and rename others (Cluster -> MutableCluster, ConstCluster -> Cluster) to adapt to the new naming scheme introduced in AIDASoft/podio#205. - The necessary changes in EDM4hep: key4hep/EDM4hep#132 would break this otherwise. Due to the explict use of Mutable* (in attachCells) this now requires a new version of edm4hep. * Update RecCalorimeter/src/components/CorrectECalBarrelSliWinCluster.cpp Co-authored-by: Brieuc Francois <brieuc.francois@cern.ch> Co-authored-by: Brieuc Francois <brieuc.francois@cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
Mutableprefix.ENDRELEASENOTES