trying on changing varible to affect the subtitle

keyanr · Oct 3, 2011 · 8cb78f7 · 8cb78f7
1 parent 9a594c2
commit 8cb78f7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/plugins/subtitle/popcorn.subtitle.js b/plugins/subtitle/popcorn.subtitle.js
@@ -2,6 +2,8 @@
 
 (function ( Popcorn ) {
 
+  var fw = "bold";
+  var fcol = "red";
   var i = 0,
       createDefaultContainer = function( context ) {
 
@@ -14,17 +16,17 @@
           // the video element must have height and width defined
           style.fontSize = "18px";
           style.width = media.offsetWidth + "px";
-          style.top = position.top  + media.offsetHeight - ctxContainer.offsetHeight - 40 + "px";
+          style.top = position.top  + "px";//+ media.offsetHeight - ctxContainer.offsetHeight - 40 
           style.left = position.left + "px";
 
           setTimeout( updatePosition, 10 );
         };
 
         ctxContainer.id = Popcorn.guid();
         style.position = "absolute";
-        style.color = "white";
-        style.textShadow = "black 2px 2px 6px";
-        style.fontWeight = "bold";
+        style.color = fcol;
+        style.textShadow = "black 12px 2px 6px";
+        style.fontWeight = fw;
         style.textAlign = "center";
 
         updatePosition();

diff --git a/plugins/subtitle/popcorn.subtitle.unit.js b/plugins/subtitle/popcorn.subtitle.unit.js
@@ -33,7 +33,7 @@ test( "Popcorn Subtitle Plugin", function() {
       text: "this is the second subtitle of 2011"
     })
   .subtitle({
-      start: 5,
+      start: 4,
       end: 7,
       text: "this is the third subtitle of 2011"
     } )