add Fullname to Bootstrap reply (#16648)

* add Fullname to Bootstrap reply

- as requested by @chrisnojima

* flow issue removal

go/engine/bootstrap.go

@@ -5,6 +5,7 @@ package engine
 
 import (
 	"context"
+	"time"
 
 	"github.com/keybase/client/go/libkb"
 	"github.com/keybase/client/go/protocol/keybase1"
@@ -44,6 +45,24 @@ func (e *Bootstrap) SubConsumers() []libkb.UIConsumer {
 	return nil
 }
 
+func (e *Bootstrap) lookupFullname(m libkb.MetaContext, uv keybase1.UserVersion) {
+	pkgs, err := m.G().UIDMapper.MapUIDsToUsernamePackagesOffline(m.Ctx(), m.G(), []keybase1.UID{uv.Uid}, time.Duration(0))
+	if err != nil {
+		m.Warning("UID -> Username failed lookup: %s", err)
+		return
+	}
+	pkg := pkgs[0]
+	if pkg.NormalizedUsername.IsNil() || pkg.FullName == nil {
+		m.Debug("Empty username for UID=%s", uv.Uid)
+		return
+	}
+	if !uv.EldestSeqno.Eq(pkg.FullName.EldestSeqno) {
+		m.Debug("Wrong eldest for username package; got %d but wanted %d", pkg.FullName.EldestSeqno, uv.EldestSeqno)
+		return
+	}
+	e.status.Fullname = pkg.FullName.FullName
+}
+
 // Run starts the engine.
 func (e *Bootstrap) Run(m libkb.MetaContext) error {
 	e.status.Registered = e.signedUp(m)
@@ -103,6 +122,8 @@ func (e *Bootstrap) Run(m libkb.MetaContext) error {
 		e.status.TopReacjis = chatHelper.TopReacjis(m.Ctx(), e.status.Uid.ToBytes())
 	}
 
+	e.lookupFullname(m, uv)
+
 	return nil
 }
 

protocol/avdl/keybase1/config.avdl

@@ -192,6 +192,7 @@ protocol config {
     string username;      // current logged in user's username
     DeviceID deviceID;      // current logged in user's device ID
     string deviceName;      // current logged in user's device name
+    FullName fullname;        // current user's fullname
     array<string> following;    // who current logged in user is following
     array<string> followers;    // who follows current logged in user
     array<string> topReacjis; // top 5 reacjis for current logged in user

shared/actions/config/index.js

@@ -65,7 +65,6 @@ function* loadDaemonBootstrapStatus(state, action) {
       deviceName: s.deviceName,
       followers: s.followers ?? [],
       following: s.following ?? [],
-      // $FlowIssue core side isn't plumbed through yet
       fullname: s.fullname || '',
       loggedIn: s.loggedIn,
       registered: s.registered,