Make hot reload work w/ rn #2452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22,6 +22,7 @@ npm-debug.log | |||
| project.xcworkspace | |||
| xcuserdata | |||
| Pods | |||
| shared | |||
There was a problem hiding this comment.
this isn't checked in now
|
@keybase/react-hackers bump |
|
Tested on Linux, seems to do the right thing (though I had to compile watchman from source), 👍 |
|
@MarcoPolo you ok with this |
|
Can we update the README with instructions? |
|
yes i wanted to make sure we're fine with this first |
|
updated |
|
👍 |
initial fonts for ios initial stylesheet
chrisnojima
force-pushed
the
nojima/DESKTOP-771-react-watch
branch
from
d745a43
to
8f524b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alrite, so this kinda sucks...
I went down the path of getting the packager to work with symlinks but its just a big PITA:
facebook/react-native#637 (comment)
Instead i made react-native/shared not be a symlink but instead be a place we just sync our files to. Not ideal but this really simplifies things. We could apply this to desktop also if we wanted.... Symlinks, while it worked, makes things hard (esp. on windows). A nice side effect of this is that the syncing filters out the desktop files.
I'll update the docs about this if we move forward with this PR
So how this works now:
brew install watchman(the npm version is old and broken)npm run watchNow when things change in client/shared it'll rsync them to react-native/shared, which'll trigger an RN packager build
@keybase/react-hackers feedback pleez