Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bring back pgp key generation #10550

Merged
merged 3 commits into from
Feb 14, 2018
Merged

bring back pgp key generation #10550

merged 3 commits into from
Feb 14, 2018

Conversation

zanderz
Copy link
Contributor

@zanderz zanderz commented Feb 14, 2018

Note that "cancel" still goes back to the people page instead of your profile - TBI?
Thanks again @buoyad

@zanderz zanderz requested a review from a team February 14, 2018 00:02
buoyad
buoyad approved these changes Feb 14, 2018
View reviewed changes
Copy link
Contributor

@buoyad buoyad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍 (but should maybe get another review)

@zanderz zanderz merged commit 42e32b4 into master Feb 14, 2018
@zanderz zanderz deleted the zanderz/DESKTOP-6076/pgp_gen branch February 14, 2018 19:27
@zanderz zanderz mentioned this pull request Feb 14, 2018
Open
@zapu zapu mentioned this pull request Feb 20, 2018
Open
@DiesDasJenes DiesDasJenes mentioned this pull request Feb 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buoyad buoyad buoyad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zanderz @buoyad