Generalize set account name popup #13603
Conversation
…-name # Conflicts: # shared/wallets/link-existing/index.js
nathanmsmith
changed the title
|
Note also this PR is based off of #13595, so I'd appreciate if you could review that too! |
|
@keybase/react-hackers |
|
bump |
| @@ -10,7 +10,7 @@ const account = { | |||
| } | |||
|
|
|||
| const load = () => { | |||
| Sb.storiesOf('Wallets/Common/Participants Row', module) | |||
| Sb.storiesOf('Wallets/Common/Account Entry', module) | |||
There was a problem hiding this comment.
Think I might have been doing a little too much copy-pasting when I did this the first time
| </Kb.Box2> | ||
| )} | ||
| <Kb.Box2 direction="vertical" style={styles.outerContainer}> | ||
| {props.onBack && <Kb.HeaderHocHeader onBack={props.onBack} headerStyle={styles.header} />} |
There was a problem hiding this comment.
Having an onBack prop in WalletPopup will be useful in cases such as closing the create new account and link existing account popups when they're opened from the send form.
| @@ -18,7 +18,6 @@ const common = { | |||
| onDone: action('onDone'), | |||
| onKeyChange: action('onKeyChange'), | |||
| onNameChange: action('onNameChange'), | |||
| onViewChange: action('onViewChange'), | |||
There was a problem hiding this comment.
onViewChange wasn't being called anywhere in the LinkExisting component; it wasn't even defined in its props.
|
I also added the autofocus props to the inputs in this PR, so this takes care of DESKTOP-7727 |
…-name # Conflicts: # shared/wallets/link-existing/index.js
| const load = () => { | ||
| Sb.storiesOf('Wallets/Common/Enter Name Popup', module) | ||
| .add('Enter name', () => <EnterNamePopup {...enterNameProps} />) | ||
| .add('Prefilled name', () => <EnterNamePopup {...enterNameProps} name="mikem's third account" />) |
There was a problem hiding this comment.
Might as well remove this + Name error from Wallets/Link existing since they're nearly dupes
This moves the "Name Account" popup into
wallets/commonand uses theWalletPopupcomponent.I'm working on another PR that uses the "Name Account" popup, so I thought I'd start by generalizing the component out of the
LinkExistingscreen.