fixup attachment caption changes #14254
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a couple things about caption change:
1.) Put a border radius on mobile video previews.
2.) Fix mouse over a video showing controls on desktop. The absolute positioned div seemed to mess with showing the controls for some reason, we just don't render it if the video is playing.
3.) Fix the height when the attachment is loading to be the correct height when the image is loaded. I was noticing the thread jump a little as a result.