New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
join fixups #19249
join fixups #19249
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if i join, leave, and then join again it's unclear if i'm in the conv or not
Right now the join/leave/join is like "mikem, mikem joined. mikem left". Is that anymore clear? |
no the status quo isn't great either |
I guess we can not consolidate in that case |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add this case to the test for this?
No description provided.