Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

join fixups #19249

Merged
merged 10 commits into from Sep 5, 2019

Conversation

@mmaxim
Copy link
Member

commented Sep 3, 2019

No description provided.

@mmaxim mmaxim requested a review from joshblum Sep 3, 2019

@joshblum
Copy link
Member

left a comment

if i join, leave, and then join again it's unclear if i'm in the conv or not

@mmaxim

This comment has been minimized.

Copy link
Member Author

commented Sep 3, 2019

Right now the join/leave/join is like "mikem, mikem joined. mikem left". Is that anymore clear?

@joshblum

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

no the status quo isn't great either

@mmaxim

This comment has been minimized.

Copy link
Member Author

commented Sep 3, 2019

I guess we can not consolidate in that case

mmaxim added 3 commits Sep 4, 2019
wip

@mmaxim mmaxim requested a review from joshblum Sep 4, 2019

@joshblum
Copy link
Member

left a comment

can you add this case to the test for this?

mmaxim added 4 commits Sep 4, 2019
wip
fix
mmaxim added 2 commits Sep 5, 2019

@mmaxim mmaxim merged commit ec49bcb into master Sep 5, 2019

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/jenkins/pr-head This commit looks good
Details

@mmaxim mmaxim deleted the mike/HOTPOT-730 branch Sep 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.