Fix Gaps in Icon Unicode Values #19270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jryio
requested review from
adamjspooner,
chrisnojima,
cecileboucheron and
nathanmsmith
jryio
force-pushed
the
thebearjew/fix-icon-codepoint-gaps
branch
from
d951409
to
812972d
Compare
chrisnojima
approved these changes
Sep 4, 2019
jryio
force-pushed
the
thebearjew/fix-icon-codepoint-gaps
branch
from
812972d
to
f31b234
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While every other part of the icon font generation was handling gaps in unicode values correctly, our final
kb.ttfwas ordering the icons sequentially.This means that
icons.constants.tsxansicons.csshad the desired unicode values for each icon, however the true unicode values inkb.ttfhad no gaps and were incorrect.After this PR, the gaps in unicode values are refelcted in
kb.ttf. This can be seen by...{counter}-kb-iconfont-{name}.svgyarn update-icon-fontsclient/shared/fonts/kb.ttf0x900Spinning up the desktop and mobile applications also reflect these changes.