Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show special unfurl when location share ends #20798

Merged
merged 12 commits into from Nov 8, 2019

Conversation

@hyperobject
Copy link
Contributor

hyperobject commented Nov 5, 2019

This PR adds a new unfurl type for when a location share has ended. This is different from the standard map unfurl so clients can remove all location data after the time has ended.

hyperobject added 5 commits Nov 4, 2019
@hyperobject hyperobject requested a review from mmaxim Nov 5, 2019
Copy link
Contributor

mmaxim left a comment

Why do you need a new type? Can't we just stick some more info on UnfurlGenericMapInfo?

@hyperobject

This comment has been minimized.

Copy link
Contributor Author

hyperobject commented Nov 6, 2019

Why do you need a new type? Can't we just stick some more info on UnfurlGenericMapInfo?

that might work? i had seen some wonkiness when sending a bunch of nil fields with mapinfo, but I think I know where those errors were coming from

@hyperobject hyperobject changed the title Add "location sharing ended" unfurl type Show special unfurl when location share ends Nov 7, 2019
@hyperobject

This comment has been minimized.

Copy link
Contributor Author

hyperobject commented Nov 7, 2019

Changed how this code works - the Coord field on UnfurlGenericMapInfo is now nullable, and when there is no coordinate to show, the frontend will show a "location share ended" unfurl. This also has a nice side effect of explicitly clearing location after a share ends so there's less chance of leaking previous locations unintentionally.

@hyperobject hyperobject requested a review from mmaxim Nov 7, 2019
hyperobject added 2 commits Nov 7, 2019
Copy link
Contributor

mmaxim left a comment

As discussed in person, try to do without changing an existing field.

hyperobject added 3 commits Nov 7, 2019
@hyperobject hyperobject requested a review from mmaxim Nov 7, 2019
@mmaxim
mmaxim approved these changes Nov 8, 2019
@hyperobject hyperobject merged commit 99fccbe into master Nov 8, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/jenkins/pr-head The build of this commit was aborted
Details
ci/circleci Your tests passed on CircleCI!
Details
@hyperobject hyperobject deleted the cori/HOTPOT-1206/end-sharing-unfurl branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.