info panel not modal #21990
info panel not modal #21990
Conversation
| @@ -3534,6 +3520,26 @@ const refreshBotSettings = async (_: Container.TypedState, action: Chat2Gen.Refr | |||
| return Chat2Gen.createSetBotSettings({conversationIDKey, settings, username}) | |||
| } | |||
|
|
|||
| const onShowInfoPanel = (action: Chat2Gen.ShowInfoPanelPayload) => { | |||
There was a problem hiding this comment.
mobile only pushes/pops the route
| @@ -1,37 +0,0 @@ | |||
| import * as React from 'react' | |||
There was a problem hiding this comment.
this file basically did nothing, so hoisting the child up a level and replacing it
| ) | ||
| const conversationIDKey: Types.ConversationIDKey = | ||
| // @ts-ignore | ||
| typeof ownProps.navigation !== 'undefined' |
There was a problem hiding this comment.
not bothering to fix these types as this needs to be cleaned up majorly
| <Conversation navigation={props.navigation} /> | ||
| {infoPanelShowing && <InfoPanel />} |
There was a problem hiding this comment.
InfoPanel lives here now
| @@ -18,7 +18,8 @@ export const isDeviceSecureAndroid: boolean = | |||
| : nativeBridge.isDeviceSecure === 'true' || false | |||
| export const isTestDevice = nativeBridge.isTestDevice | |||
|
|
|||
| export const isRemoteDebuggerAttached = typeof __REMOTEDEV__ !== 'undefined' | |||
| // @ts-ignore | |||
| export const isRemoteDebuggerAttached: boolean = typeof DedicatedWorkerGlobalScope !== 'undefined' | |||
There was a problem hiding this comment.
this never worked on ios, and likely never worked on android
| @@ -194,6 +194,8 @@ export type State = Readonly<{ | |||
| inboxLayout: RPCChatTypes.UIInboxLayout | null // layout of the inbox | |||
| inboxSearch?: InboxSearchInfo | |||
| inboxShowNew: boolean // mark search as new, | |||
| infoPanelShowing: boolean | |||
| infoPanelSelectedTab: 'settings' | 'members' | 'attachments' | 'bots' | undefined | |||
There was a problem hiding this comment.
have to keep track of this in the store for desktop now
|
Agreed (on the width). |
|
Probably was constrained by the animation container before. Likely a 1 liner |
|
Behavior is a little weird if you are on a "members" tab from a team, then land on an imp team, since it doesn't have that tab. |
|
I think the best fix for that Membes tab situation is to actually maintain two saved tabs, one for teams and one for ad hoc. Since if you just say "if current tab members, and on ad hoc conv, set to attachments" you keep switching the team convs over to attachments, even if you want it to stay on members. @adamjspooner might have an opinion here. |
|
Seems okay to me. 👍 |
|
We can maybe move this to another PR, but I think this thing needs some kind of loading state when entering a conv. It was less of a problem before since it wasn't likely to click into a conv and immediately hit the info panel, but now if you go into a conv with a ton of people, and you have the info panel open, you just look at a blank state with no spinner while we churn away loading everything. |
|
As mentioned here how this works internally needs attention. I think we should do it in another pr. It can happen this sprint |
|
@mmaxim we ok to merge this |
|
Fine to merge, but we need to fix that Members tab thing before release. |
|
@mmaxim merging when ci passes |
note: there is a known issue where if you click on the info panel, click an image, then click all media, then click back the attachments are gone. how state is managed and how the info panel (in general) is organized is a huge mess and needs to be refactored