Hook up teamEditMembers for editing multi members

protocol/bin/enabled-calls.json

@@ -317,7 +317,7 @@
   "keybase.1.teams.teamCreateSeitanInvitelinkWithDuration": {"promise": true},
   "keybase.1.teams.teamCreateSeitanTokenV2": {"promise": true},
   "keybase.1.teams.teamDelete": {"engineSaga": true, "promise": true},
-  "keybase.1.teams.teamEditMember": {"promise": true},
+  "keybase.1.teams.teamEditMembers": {"promise": true},
   "keybase.1.teams.teamGet": {"promise": true},
   "keybase.1.teams.teamGetByID": {"promise": true},
   "keybase.1.teams.teamGetMembers": {"promise": true},

shared/actions/json/teams.json

@@ -203,8 +203,9 @@
       "teamname": "string"
     },
     "editMembership": {
+      "_description": "Edit the role of one or more members in a team",
       "teamID": "Types.TeamID",
-      "username": "string",
+      "usernames": "Array<string>",
       "role": "Types.TeamRoleType"
     },
     "removeMember": {

shared/actions/teams.tsx

@@ -452,19 +452,22 @@ const uploadAvatar = async (action: TeamsGen.UploadTeamAvatarPayload, logger: Sa
   }
 }
 
-const editMembership = async (state: TypedState, action: TeamsGen.EditMembershipPayload) => {
-  const {teamID, username, role} = action.payload
+const editMembership = async (action: TeamsGen.EditMembershipPayload) => {
+  const {teamID, usernames, role: _role} = action.payload
+  const role = _role ? RPCTypes.TeamRole[_role] : RPCTypes.TeamRole.none
   try {
-    await RPCTypes.teamsTeamEditMemberRpcPromise(
+    await RPCTypes.teamsTeamEditMembersRpcPromise(
       {
-        name: Constants.getTeamNameFromID(state, teamID) ?? '',
-        role: role ? RPCTypes.TeamRole[role] : RPCTypes.TeamRole.none,
-        username,
+        teamID,
+        users: usernames.map(assertion => ({assertion, role})),
       },
-      [Constants.teamWaitingKey(teamID), Constants.editMembershipWaitingKey(teamID, username)]
+      [Constants.teamWaitingKey(teamID), Constants.editMembershipWaitingKey(teamID, ...usernames)]
     )
   } catch (e) {
-    return TeamsGen.createSetEditMemberError({error: e.message, teamID, username})
+    if (usernames.length === 1) {
+      // error is shown in the member page
+      return TeamsGen.createSetEditMemberError({error: e.message, teamID, username: usernames[0]})
+    }
   }
   return false
 }
@@ -1697,7 +1700,7 @@ const teamsSaga = function*() {
   yield* Saga.chainAction(TeamsGen.editTeamDescription, editDescription)
   yield* Saga.chainAction(TeamsGen.uploadTeamAvatar, uploadAvatar)
   yield* Saga.chainAction2(TeamsGen.createChannels, createChannels)
-  yield* Saga.chainAction2(TeamsGen.editMembership, editMembership)
+  yield* Saga.chainAction(TeamsGen.editMembership, editMembership)
   yield* Saga.chainGenerator<TeamsGen.RemoveMemberPayload>(TeamsGen.removeMember, removeMember)
   yield* Saga.chainGenerator<TeamsGen.RemovePendingInvitePayload>(
     TeamsGen.removePendingInvite,

shared/constants/teams.tsx

@@ -51,8 +51,8 @@ export const loadWelcomeMessageWaitingKey = (teamID: Types.TeamID) => `loadWelco
 export const setWelcomeMessageWaitingKey = (teamID: Types.TeamID) => `setWelcomeMessage:${teamID}`
 export const loadTeamTreeActivityWaitingKey = (teamID: Types.TeamID, username: string) =>
   `loadTeamTreeActivity:${teamID};${username}`
-export const editMembershipWaitingKey = (teamID: Types.TeamID, username: string) =>
-  `editMembership:${teamID};${username}`
+export const editMembershipWaitingKey = (teamID: Types.TeamID, ...usernames: Array<string>) =>
+  `editMembership:${teamID};${usernames.join(',')}`
 export const updateChannelNameWaitingKey = (teamID: Types.TeamID) => `updateChannelName:${teamID}`
 
 export const initialMemberInfo = Object.freeze<Types.MemberInfo>({

shared/teams/common/selection-popup.tsx

@@ -286,9 +286,7 @@ const EditRoleButton = ({members, teamID}: {teamID: Types.TeamID; members: strin
 
   const [showingPicker, setShowingPicker] = React.useState(false)
 
-  const waiting = Container.useAnyWaiting(
-    ...members.map(username => Constants.editMembershipWaitingKey(teamID, username))
-  )
+  const waiting = Container.useAnyWaiting(Constants.editMembershipWaitingKey(teamID, ...members))
 
   // We wait for the teamLoaded action
   const waitForTeamLoaded = React.useCallback((a: Container.TypedActions) => {
@@ -302,8 +300,8 @@ const EditRoleButton = ({members, teamID}: {teamID: Types.TeamID; members: strin
     Constants.getDisabledReasonsForRolePicker(state, teamID, members)
   )
   const disableButton = disabledReasons.admin !== undefined
-  const onChangeRoles = role =>
-    members.forEach(username => dispatch(TeamsGen.createEditMembership({role, teamID, username})))
+  const onChangeRoles = (role: Types.TeamRoleType) =>
+    dispatch(TeamsGen.createEditMembership({role, teamID, usernames: members}))
 
   return (
     <FloatingRolePicker

shared/teams/team/member/container.tsx

@@ -71,7 +71,7 @@ export default Container.connect(
         dispatch(Chat2Gen.createPreviewConversation({participants: [username], reason: 'memberView'}))
     },
     _onEditRole: (teamID: Types.TeamID, username: string, role: Types.TeamRoleType) =>
-      dispatch(TeamsGen.createEditMembership({role, teamID, username})),
+      dispatch(TeamsGen.createEditMembership({role, teamID, usernames: [username]})),
     _onRemoveMember: (teamID: Types.TeamID, username: string) => {
       dispatch(
         RouteTreeGen.createNavigateAppend({

shared/teams/team/member/index.new.tsx

@@ -505,7 +505,7 @@ const NodeInRow = (props: NodeInRowProps) => {
   const [open, setOpen] = React.useState(false)
   const onChangeRole = (role: Types.TeamRoleType) => {
     setRole(role)
-    dispatch(TeamsGen.createEditMembership({role, teamID: props.node.teamID, username: props.username}))
+    dispatch(TeamsGen.createEditMembership({role, teamID: props.node.teamID, usernames: [props.username]}))
     setOpen(false)
     if (['reader, writer'].includes(role) && props.isParentTeamMe) {
       dispatch(nav.safeNavigateUpPayload())