New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix keybase chat sends during packaging #25373

Merged

joshblum merged 1 commit into master from joshblum/fix-package-notifs

Dec 21, 2022

Member

joshblum commented Dec 21, 2022 •

edited

fixes this which has popped up in the packaging logs:

$ KEYBASE_CONV_ID=xxx ./packaging/slack/send.sh "hi \n
asdfa"
hi \n
asdfa
Sending to Keybase convID: xxx
{"error":{"code":0,"message":"invalid character '\\n' in string escape code"}}

$ KEYBASE_CONV_ID=xxx ./packaging/slack/send.sh "hi"
hi
Sending to Keybase convID: xxx
{"error":{"code":0,"message":"invalid JSON: expected more JSON in input"}}


          fix keybase chat sends during packaging

41cae16

mmaxim approved these changes

View reviewed changes

joshblum merged commit 1204ce5 into master

joshblum deleted the joshblum/fix-package-notifs branch

December 21, 2022 17:06

joshblum added a commit that referenced this pull request


          fix keybase chat sends during packaging (#25373)

56357af

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment