loosen the merkle gap check #26258
Merged
loosen the merkle gap check #26258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songgao-zoom
force-pushed
the
songgao/loosen-merkle-gap-check
branch
from
2ad5541
to
75ba466
Compare
strib
approved these changes
Feb 16, 2024
go/kbfs/libkbfs/md_ops.go
Outdated
| // we shouldn't be trusting the server. TODO: reduce this once | ||
| // merkle computation is faster. | ||
| maxAllowedMerkleGap = maxAllowedMerkleGapServer + 15*time.Minute | ||
| // Update 2024-02-16: we decided to disable the merkle gap check (by |
There was a problem hiding this comment.
I'm not sure we're disabling it anymore. Maybe "weaken"?
joshblum
pushed a commit
that referenced
this pull request
Feb 29, 2024
mmaxim
pushed a commit
that referenced
this pull request
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@strib @maxtaco @jzila @mmaxim
increase it a bit any way in case
mdmerklegoes down to give us more time to fix it.