Fix showing a first timestamp at the start of a convo #5881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had this working before -- there's a "tlfName" type message at the start of every conversation, and we were using the fact that this is an Unhandled message to trigger showing a leading timestamp before the first message, even though a timestamp is normally between two messages. But then we added a filter for the type of messages we want to be told about inside a conversation, and we removed "tlfName" from the list, so we didn't get that leading Unhandled message anymore, and the first timestamp went away. This PR just adds tlfName messages back in. I verified that this gives us a leading timestamp again and doesn't appear to have any negative effects (e.g. I don't see any new error messages in chats).
|
@keybase/react-hackers ^ |
chrisnojima
approved these changes
Feb 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had this working before -- there's a "tlfName" type message at the start of every conversation, and we were using the fact that this is an Unhandled message to trigger showing a leading timestamp before the first message, even though a timestamp is normally between two messages.
But then we added a filter for the type of messages we want to be told about inside a conversation, and we removed "tlfName" from the list, so we didn't get that leading Unhandled message anymore, and the first timestamp went away.
This PR just adds tlfName messages back in. I verified that this gives us a leading timestamp again and doesn't appear to have any negative effects (e.g. I don't see any new error messages in chats).