don't return any error from already open team #9888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjb
approved these changes
Dec 12, 2017
|
I guess this PR could also remove the condition around the call to the open team RPC in actions/teams/index.js _setPublicity, since now it's only potentially causing the set to not be saved if there's confusion about what the active state is. |
maxtaco
approved these changes
Dec 12, 2017
mmaxim
force-pushed
the
mike/errorsmash
branch
from
3ba587c
to
e4f962a
Compare
|
Maybe make another PR for the JS side, I think there is likely a bug there too @cjb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just log and return here instead of returning an error.
cc @zapu @cjb