Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use generated types from AVDL #21

Merged
merged 28 commits into from Aug 29, 2019
Merged

Conversation

nathanmsmith
Copy link

@nathanmsmith nathanmsmith commented Aug 19, 2019

Take advantage of node-avdl-compiler 1.4.1 to generate our types.

Some notes:

  • Since this changes some variable names, this would be a breaking change. I have "Version 2" project to track other changes I think would make sense to go in a 2.0. It seems like the two ways to upgrade version in go is to create a version git tag, separate v2 branch, or v2 subdirectory in the repo. Would love to hear which approach y'all like best, I'm leaning towards tagging.
  • I added a Makefile to generate the types from this repo. The Makefile utilizes the tooling inside the client repo.
  • The README and examples should be updated.

@nathanmsmith nathanmsmith changed the title Nathan/picnic 264 generated types Use generated types from AVDL Aug 23, 2019
@nathanmsmith nathanmsmith added this to In Progress in Version 2 Aug 23, 2019
@nathanmsmith nathanmsmith marked this pull request as ready for review August 23, 2019 21:54
@nathanmsmith nathanmsmith force-pushed the nathan/PICNIC-264-generated-types branch from 1c14602 to cc047ff Compare August 26, 2019 13:49
@nathanmsmith nathanmsmith force-pushed the nathan/PICNIC-264-generated-types branch from cc047ff to ed95be7 Compare August 28, 2019 18:35
@@ -9,3 +9,8 @@ linters:
- gofmt
- gocritic
- unconvert
- govet
- golint
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved govet and golint to be run by golanglint-ci instead of separately. Main reason for this is that it allows us to specify the same ignore config for all linters, but I believe it'd would also be faster?

@@ -2,12 +2,11 @@ language: go

before_install:
- go get golang.org/x/lint/golint
- make dependencies
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have a makefile in your go project, travis won't auto detect and install dependencies; it expects you to have a task for that.

@mmaxim
Copy link
Collaborator

mmaxim commented Aug 29, 2019

Why not just vendor the types in, why do we need to generate them in here?

@nathanmsmith nathanmsmith merged commit 15c0ee3 into master Aug 29, 2019
@nathanmsmith nathanmsmith deleted the nathan/PICNIC-264-generated-types branch August 29, 2019 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Version 2
In Review
Development

Successfully merging this pull request may close these issues.

None yet

2 participants