New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use generated types from AVDL #21
Conversation
1c14602
to
cc047ff
Compare
cc047ff
to
ed95be7
Compare
@@ -9,3 +9,8 @@ linters: | |||
- gofmt | |||
- gocritic | |||
- unconvert | |||
- govet | |||
- golint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved govet
and golint
to be run by golanglint-ci instead of separately. Main reason for this is that it allows us to specify the same ignore config for all linters, but I believe it'd would also be faster?
@@ -2,12 +2,11 @@ language: go | |||
|
|||
before_install: | |||
- go get golang.org/x/lint/golint | |||
- make dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you have a makefile in your go project, travis won't auto detect and install dependencies; it expects you to have a task for that.
Why not just vendor the types in, why do we need to generate them in here? |
Take advantage of node-avdl-compiler 1.4.1 to generate our types.
Some notes: