Use generated wallet types for wallet functions #14
Conversation
|
I guess this would remove the need for #17. Is there a reason for generating the types vs including them from keybase/client/go? |
|
@marceloneil We've been debating this internally, and I see the argument both ways. At least to start, I think it makes more sense to generate the type so people don't have to install an additional dependency/code they don't need and as a proof of concept for other languages, as we'd like to generate all of the same types for our Go, Python, and TypeScript bots. Our AVDL->Go compiler just happens to be the furthest along. This very well could change in the future! Would love to hear your thoughts on it. |
|
Oh I see, it makes a lot of sense if you want to keep this implementation similar to other language implementations. How do you plan on dealing with versioning? Would you make releases to this package when the client makes a release? |
|
We're working on adding a task to the client repo to auto-update the bot repo types. We'll likely only push updates when additions or changes are made to the underlying API types, as there are a lot of types in the defined avro files that are used elsewhere by the app. When those happen, I'd actually expect the bot libraries to be updated shortly after changes hit in the nightly builds. I suppose we should talk about timing our stable bot releases with stable client releases, we haven't had that conversation yet! |
|
Sounds good, hope this gets merged in soon! |
|
speaking of which... bump @xgess? 🙂 |
|
Closing this out in favor of #21 |
Replaces our (admittedly small) wallet types used in
kbchat/wallet.gowith generated types from our AVDL. I generated these files on the branch used in keybase/client#18623.Note that chat types, while added in the
types/dir, remain unused bykbchatin favor of its own definitions. I'll change that in a future PR, but figured I'd try to minimize this diff as much as possible.