use SHGetKnownFolderPath, local instead of roaming #126
Conversation
| if dir == "" { | ||
| return "", fmt.Errorf("No APPDATA env set") | ||
| dir, err := LocalDataDir() | ||
| if err != nil || dir == "" { |
There was a problem hiding this comment.
I think you want to break this up...
if err != nil { return "", err }
if dir == "" { return "", fmt.Errorf("No APPDATA env set") }
|
|
||
| // F1B32785-6FBA-4FCF-9D55-7B8E7F157091 | ||
| var ( | ||
| FOLDERID_LocalAppData = GUID{0xF1B32785, 0x6FBA, 0x4FCF, [8]byte{0x9D, 0x55, 0x7B, 0x8E, 0x7F, 0x15, 0x70, 0x91}} |
There was a problem hiding this comment.
maybe this varname could be FolderIDLocalAppData
There was a problem hiding this comment.
This name is directly from the API, it seems better that it matches: https://msdn.microsoft.com/en-us/library/windows/desktop/dd378457(v=vs.85).aspx
There was a problem hiding this comment.
Maybe we could put a comment here explaining what the var is and that it corresponds to FOLDERID_LocalAppData and the link to that page... Just want to keep the linter happy.
| "golang.org/x/sys/windows/registry" | ||
| ) | ||
|
|
||
| type GUID struct { |
There was a problem hiding this comment.
I think a lot of these structs & methods could be private? ... e.g. type guid struct
|
|
||
| func coTaskMemFree(pv uintptr) { | ||
| syscall.Syscall(procCoTaskMemFree.Addr(), 1, uintptr(pv), 0, 0) | ||
| return |
| folder := syscall.UTF16ToString((*[1 << 16]uint16)(unsafe.Pointer(pszPath))[:]) | ||
|
|
||
| if len(folder) == 0 { | ||
| return "", errors.New("can't get AppData directory") |
There was a problem hiding this comment.
I think most of our errors are title cased... "Can't...
| var pszPath uintptr | ||
| r0, _, _ := procSHGetKnownFolderPath.Call(uintptr(unsafe.Pointer(&id)), uintptr(0), uintptr(0), uintptr(unsafe.Pointer(&pszPath))) | ||
| if r0 != 0 { | ||
| return "", errors.New("can't get FOLDERID_RoamingAppData") |
There was a problem hiding this comment.
I think most of our errors are title cased... "Can't...
| return "", errors.New("can't get FOLDERID_RoamingAppData") | ||
| } | ||
|
|
||
| defer coTaskMemFree(pszPath) |
There was a problem hiding this comment.
Do we need to check pszPath is invalid?
|
lg2m with some comments... Bump the version too? |
Use system APIs instead of relying on the environment variable. Matching PRs in client and kbfs.
@maxtaco @gabriel