Skip to content
This repository has been archived by the owner on Feb 12, 2019. It is now read-only.

Be consistent with official docs in systemd service file #1535

Closed
wants to merge 1 commit into from

Conversation

kgizdov
Copy link

@kgizdov kgizdov commented Mar 29, 2018

Service file kbfs.service uses the keyword mountdir to get configured mount point from user configuration and mount keybase FS. However, the official documentation say that users should set the entry for keyword mountpoint instead. Thus users are left with bad configuration until they manually dig this up and fix it themselves.

@eli-schwartz
Copy link
Contributor

Pretty sure it is the docs which are wrong, e.g.

https://github.com/keybase/client/blob/v1.0.46/packaging/linux/run_keybase#L13

@eli-schwartz
Copy link
Contributor

eli-schwartz commented Mar 30, 2018

@strib
Copy link
Contributor

strib commented Mar 30, 2018

However, the official documentation say that users should set the entry for keyword mountpoint instead.

@kgizdov which "official documentation" are you referring to? https://keybase.io/docs/kbfs/understanding_kbfs correctly says mountdir.

@eli-schwartz
Copy link
Contributor

No idea but FWIW this came together with a bugreport to Arch which claims the service file is also somehow wrong because fusermount is reporting no mountpoint in /etc/mtab (works for me, pretty sure fusermount is not broken, guessing this is just the case where ExecStartPre is permitted to fail because nothing needed to be unmounted).

https://bugs.archlinux.org/task/58032

@kgizdov
Copy link
Author

kgizdov commented Apr 3, 2018

@strib I swear that page said mountpoint when I looked at it before Easter. I guess this doesn't apply anymore.

@kgizdov kgizdov closed this Apr 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants