New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility issues with Keybase website #1934
Comments
Here's some W3 documentation pertaining to As for the edit/update, I'm not entirely sure that it will end up working for you without being rewritten, unfortunately. |
I'm working on issue 1, adding aria-labels to buttons without clear link text. Sorry!
Interesting. I can fully get to these links and click them using just my keyboard, and no mouse. In my browser removing focus from the popup menu doesn't close it. Hmm! That makes it hard to debug. I'm using a bootstrap component for that popup. |
Huh, OK, I take back #2, I am able to reach the links via keyboard.
Earlier this morning I wasn't and the behavior was different. Had a pint
of coffee between then and now so that's probably it. :)
Either way, might be worth marking that up with ARIA, maybe as a
dropdown, then move keyboard focus to the first link when the Edit link
is activated. Otherwise there is no indication that this is a dropdown.
My expectation was that it'd pop up an entirely separate page, and I
always do a bit of poking around the page when nothing happens to ensure
that content wasn't appended/prepended to the DOM. See, for example,
clicking on the key ID. Took a minute or so to find the text area
containing the ASCII for the public key.
Thanks for the quick responses! This is encouraging.
|
can you check the aria-labels now? |
Nice! Much better, thanks.
One link is still unlabeled. Looks like the link to edit pics near my
full name.
|
ok, fixed the pic editing one. it should have the aria-label now too. I haven't implemented a focus change yet as you said (that'll be a bit more work based on the way the contents of the dropdown are abstracted away), but as of 30 seconds ago I also added aria label to the dropdown links to suggest they're dropdowns. For example, the one for editing your PGP key. So that way it will be less confusing if you choose it (I hope). |
Nice, thanks.
There are also labels missing from the device list page.
|
Hi. |
at the moment keybace has serious problems with the accessibility of android and electron applications. it would be great if someone worked on this. |
I'm blind, and am attempting to use the Keybase website. I'd like to use your CLI but am having issues logging in with it, so in the meantime I'm attempting to resolve the issue from the website.
<a/>
with no text content or something similar) which I'm guessing are icons. Please addaria-label
atttributes to these links so my screen reader identifies them.Thanks.
The text was updated successfully, but these errors were encountered: