Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error in the wild: Found a later subchain with eldest kid #11

Closed
maxtaco opened this issue Sep 23, 2015 · 4 comments
Closed

error in the wild: Found a later subchain with eldest kid #11

maxtaco opened this issue Sep 23, 2015 · 4 comments
Assignees
Milestone

Comments

@maxtaco
Copy link
Contributor

maxtaco commented Sep 23, 2015

See keybase/keybase-issues#1769

@maxtaco maxtaco added this to the Sprint 4 milestone Sep 23, 2015
@oconnor663
Copy link
Contributor

The server needs to enforce that we don't reuse eldest keys. (Bit of a hack, but it'll matter less when most eldest keys are device keys.)

@oconnor663 oconnor663 self-assigned this Sep 25, 2015
@oconnor663
Copy link
Contributor

Server-side fix: https://github.com/keybase/keybase/pull/478

@oconnor663
Copy link
Contributor

As part of this, we need to update the node client to go down the is_update codepath on key/add.json.

@oconnor663
Copy link
Contributor

I was wrong, no client change is needed. This is done. (Just confirmed by creating an account with the node client, making a few sigs, running keybase revoke to nuke everything, and then trying to keybase push the same eldest key again.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants