Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

end of the line for the node app #221

Merged
merged 3 commits into from Jul 22, 2016
Merged

end of the line for the node app #221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a96907f
end of the line for the node app
maxtaco Jul 22, 2016
d4c2d5a
README update too
maxtaco Jul 22, 2016
b72ab7e
comment from review
maxtaco Jul 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
@@ -1,3 +1,8 @@
## 0.8.26 (2016-07-21)

END OF LIFE
- Disable all access and redirect to: https://keybase.io/download

## 0.8.25 (2015-11-30)

bugfix:
Expand Down
6 changes: 5 additions & 1 deletion README.md
View file
Open in desktop
@@ -1,7 +1,11 @@
node-client
===========

The terminal client for keybase written in/for Node.js. Code reviews appreciated.
## END OF LIFE WARNING

This Keybase app is no longer supported. Active development [continues](https://github.com/keybase/client) [elsewhere](https://github.com/keybase/kbfs).

Upgrade to our new client via our [download page.](https://keybase.io/download)

### Issue tracking & reporting

Expand Down
95 changes: 60 additions & 35 deletions lib/command/all.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 18 additions & 2 deletions src/command/all.iced
View file
Open in desktop
Expand Up @@ -18,6 +18,7 @@ tor = require '../tor'
colors = require '../colors'
{check_node_async} = require 'badnode'
ispawn = require 'iced-spawn'
colors_base = require 'colors'

##=======================================================================

Expand Down Expand Up @@ -169,14 +170,29 @@ class Main
if err?
msg = if (err instanceof gpgw.E.GpgError) then "`gpg` exited with code #{err.rc}"
else err.message
log.error msg
log.warn err.stderr.toString('utf8') if err.stderr?
# No need to print error, since it's end of life...
# log.error msg
# log.warn err.stderr.toString('utf8') if err.stderr?
process.exit if err? then -2 else rc

#---------------------------------

end_of_life : (cb) ->
{bold, red} = colors_base
msg = (m) -> console.error bold red m
msg "The Keybase Node.js client is no longer supported."
msg "Please upgrade to our new and improved client via:"
msg ""
msg " https://keybase.io/download"
msg ""
msg "Thank you!"
cb new Error "end of the line"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just call process.exit here and avoid having to gut the error handling? :)


#---------------------------------

run : (cb) ->
esc = make_esc cb, "run"
await @end_of_life esc defer()
await @setup esc defer()
await @cmd.run esc defer rc
cb null, rc
Expand Down