plumb through dohash; fix client section #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- we mistakenly had body.client, but it should be .client, to match what Go generats - the `dohash` field we plumb through affects how signtures are created, most useful for the sigchain forge - reattempt
maxtaco
commented
Feb 21, 2020
| @@ -542,7 +542,7 @@ class Base | |||
|
|
|||
| ret.high_skip = @high_skip if @high_skip? | |||
|
|
|||
| ret.body.client = @client if @client? | |||
| ret.client = @client if @client? | |||
There was a problem hiding this comment.
do you think this horks anything?
There was a problem hiding this comment.
not anything I can think of right now
zapu
approved these changes
Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dohashfield we plumb through affects how signtures are created, most useful for the sigchain forge