fix bugs in team reverse sigs and beef up testing #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oconnor663
reviewed
May 9, 2017
src/subkey.iced
Outdated
| json?.body?[@get_field()]?[@sibkid_slot()] | ||
| _clear_reverse_sig : (outer) -> | ||
| # body.sibkey.reverse_sig should be the only field different between the two | ||
| outer?.body?[@get_field()].reverse_sig = null |
oconnor663
reviewed
May 9, 2017
src/subkey.iced
Outdated
| @@ -66,20 +65,28 @@ exports.SubkeyBase = class SubkeyBase extends Base | |||
| await @reverse_sig_check { json, new_km: @get_new_km() }, esc defer() | |||
| cb null | |||
|
|
|||
| _get_reverse_sig : (json) -> | |||
| json?.body?[@get_field()]?.reverse_sig | |||
There was a problem hiding this comment.
Since we're in here, should we call get_field something more descriptive?
oconnor663
reviewed
May 9, 2017
| @per_team_key = m | ||
| get_new_km : () -> @kms?.signing # use the signing KM | ||
| sibkid_slot : () -> "signing_kid" | ||
| need_reverse_sig : (json) -> json?.body?.per_team_key? | ||
| need_reverse_sig : (json) -> json?.body?.team?.per_team_key? |
There was a problem hiding this comment.
It looks like we're not implementing sibkid_slot anymore. Is it ok that we inherit the parent implementation that returns "kid"? It looks like we're signing ourselves up to override all parent methods that call sibkid_slot, but that sounds like a tricky contract?
oconnor663
reviewed
May 9, 2017
| await obj2.verify_v2 varg, defer err | ||
| if corrupt | ||
| T.assert err?, "got an error back" | ||
| T.assert (err.message.indexOf('Reverse sig json mismatch') >= 0), "found right error message" |
There was a problem hiding this comment.
Should we be asserting anything in the !corrupt case? It does look like we mean to test that case below.
|
Thanks for the review, all fixed! |
|
LGTM thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.